Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move visual tests to src/test/renderer #1717

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Move visual tests to src/test/renderer #1717

merged 4 commits into from
Sep 29, 2021

Conversation

srmagura
Copy link
Contributor

@srmagura srmagura commented Sep 29, 2021 •
edited
Loading

Working towards completing #1556.

Btw, the visual regression tests workflow seems to be broken. I'm not sure if I broke it or if it was already like this. The visual tests work when I run them locally.

Run npx reg-suit run --test
[reg-suit] info version: 0.10.16
[reg-suit] info Skipped to detect the previous snapshot key because key generator plugin is not set up.
[reg-suit] info Skipped to fetch the expected data because expected key is null.
[reg-suit] info Comparison Complete
[reg-suit] info    Changed items: 0
[reg-suit] info    New items: 0
[reg-suit] info    Deleted items: 0
[reg-suit] info    Passed items: 0
[reg-suit] info Use 'snapshot_1632892749' as the current snapshot key because key generator plugin is not set up.
[reg-suit] info Skipped to publish the snapshot data because publisher plugin is not set up.
[reg-suit] info Skipped to notify result because notifier plugins are not set up.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 29, 2021

I'm guessing the visual regression workflow is broken because of the moving, and that it's not something you did/could prevent, I suspect it'll start working once PRs are based on commits after this is merged.

Gerrit0
Gerrit0 requested changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, then this looks good

src/test/renderer/self/run Outdated Show resolved Hide resolved
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 29, 2021

Thanks!

@Gerrit0 Gerrit0 merged commit 6a1575f into TypeStrong:master Sep 29, 2021
@srmagura srmagura deleted the rename-visual-tests branch September 29, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit0 Gerrit0 Awaiting requested review from Gerrit0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srmagura @Gerrit0